[webkit-reviews] review granted: [Bug 232185] ASSERT(parent->element()) triggered in Styleable::fromRenderer : [Attachment 442385] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 232185: ASSERT(parent->element()) triggered in Styleable::fromRenderer
https://bugs.webkit.org/show_bug.cgi?id=232185

Attachment 442385: Patch

https://bugs.webkit.org/attachment.cgi?id=442385&action=review




--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 442385
  --> https://bugs.webkit.org/attachment.cgi?id=442385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442385&action=review

>>> Source/WebCore/ChangeLog:10
>>> +	     loop through parent renderers as ::backdrop and ::marker renderers
do not
>> 
>> the problem here is that RenderMultiColumnFlowThread don't have associated
renderers, so we have to loop through parents until we find the RenderListItem
which has an associated element.
> 
> don't have associated elements*

CSS term for a renderer without an associated element is "anonymous box"