[webkit-reviews] review granted: [Bug 232294] Have ImageDiff print the diff image when any pixel is different : [Attachment 442460] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 232294: Have ImageDiff print the diff image when any pixel is different
https://bugs.webkit.org/show_bug.cgi?id=232294

Attachment 442460: Patch

https://bugs.webkit.org/attachment.cgi?id=442460&action=review




--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 442460
  --> https://bugs.webkit.org/attachment.cgi?id=442460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442460&action=review

I like where this is heading.

> Tools/Scripts/webkitpy/port/image_diff.py:133
> +	   if diff_output:

I wonder if this should print some sort of warning is there is no diff_output?