[webkit-reviews] review granted: [Bug 231250] FileSystemHandle should be ContextDestructionObserver : [Attachment 442384] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 02:03:02 PDT 2021


youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 231250: FileSystemHandle should be ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=231250

Attachment 442384: Patch

https://bugs.webkit.org/attachment.cgi?id=442384&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 442384
  --> https://bugs.webkit.org/attachment.cgi?id=442384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442384&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h:57
> +    FileSystemHandle(ScriptExecutionContext*, Kind, String&& name,
FileSystemHandleIdentifier, Ref<FileSystemStorageConnection>&&);

We usually go with ScriptExecutionContext&

> Source/WebCore/Modules/storage/StorageManager.cpp:122
> +	   auto* context = weakNavgiator ?
weakNavgiator->scriptExecutionContext() : nullptr;

s/weakNavgiator/weakNavigator


More information about the webkit-reviews mailing list