[webkit-reviews] review granted: [Bug 232292] [ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari : [Attachment 442454] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 25 19:45:38 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 232292: [ App Privacy Report ] Restoring a session after clearing the cache
results in app initiated loads in Safari
https://bugs.webkit.org/show_bug.cgi?id=232292

Attachment 442454: Patch

https://bugs.webkit.org/attachment.cgi?id=442454&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 442454
  --> https://bugs.webkit.org/attachment.cgi?id=442454
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442454&action=review

R=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898
> +    if (documentLoader)

If document!oader isn’t used elsewhere, I’d just declare it in the if
statement:

If (auto* documentLoadwr = corePage()….


More information about the webkit-reviews mailing list