[webkit-reviews] review granted: [Bug 232246] Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue() : [Attachment 442381] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 25 10:27:43 PDT 2021
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 232246: Refactor CSSToStyleMap::mapAnimationTimingFunction() to use
TimingFunction::createFromCSSValue()
https://bugs.webkit.org/show_bug.cgi?id=232246
Attachment 442381: Patch
https://bugs.webkit.org/attachment.cgi?id=442381&action=review
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 442381
--> https://bugs.webkit.org/attachment.cgi?id=442381
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=442381&action=review
> Source/WebCore/css/CSSToStyleMap.cpp:-461
> - return;
Might as well keep the return and use "if" instead of "else if".
More information about the webkit-reviews
mailing list