[webkit-reviews] review canceled: [Bug 232140] [CSS-grid] Need to set prefer width dirty for the child that has constraints to the grid area : [Attachment 442148] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has canceled  review:
Bug 232140: [CSS-grid] Need to set prefer width dirty for the child that has
constraints to the grid area
https://bugs.webkit.org/show_bug.cgi?id=232140

Attachment 442148: Patch

https://bugs.webkit.org/attachment.cgi?id=442148&action=review




--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 442148
  --> https://bugs.webkit.org/attachment.cgi?id=442148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442148&action=review

> Source/WebCore/ChangeLog:9
> +	   reset the OverrideContainingBlockLogicalWidth value when we are
executing a definite strategy.

This is only performed when the Direction() is the InlineAxis (kForColumns if
it's not an orthogonal item). However, the
updateOverridingContainingBlockContentSizeForChild() call is executed when we
are processing the BlockAxis direction (kForRows under the alerady mentioned
assumption of a parallel item).

> Source/WebCore/ChangeLog:12
> +

I'm not sure this is correct. The grid item's preferred width shouldn't depend
on its containing block (the grid area in this case) size, should it ?