[webkit-reviews] review granted: [Bug 231161] REGRESSION (iOS 15): Safari shows zoom callout even if -webkit-user-select is none : [Attachment 442284] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 231161: REGRESSION (iOS 15): Safari shows zoom callout even if
-webkit-user-select is none
https://bugs.webkit.org/show_bug.cgi?id=231161

Attachment 442284: Patch

https://bugs.webkit.org/attachment.cgi?id=442284&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 442284
  --> https://bugs.webkit.org/attachment.cgi?id=442284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442284&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2898
> +	       if (isAssistableElement(*downcast<Element>(hitNode)))

Not too fond of checking if not text but then casting to Element. Why not make
the check and the downcast match? Also could use *node.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2912
> +	   return;

Do we want to set isSelected to false here? Or is it valuable to leave the
other fields with old values? Or are these always set to the default values in
practice? Can’t tell from this function alone, but maybe due to how it’s used.