[webkit-reviews] review granted: [Bug 232212] Add an ImageDiff option to print out WPT-style pixel differences : [Attachment 442291] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 232212: Add an ImageDiff option to print out WPT-style pixel differences
https://bugs.webkit.org/show_bug.cgi?id=232212

Attachment 442291: Patch

https://bugs.webkit.org/attachment.cgi?id=442291&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 442291
  --> https://bugs.webkit.org/attachment.cgi?id=442291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442291&action=review

r=me even though this current version of the patch doesn’t apply yet

> Tools/ImageDiff/ImageDiff.cpp:52
> +static int processImages(std::unique_ptr<PlatformImage>&& actualImage,
std::unique_ptr<PlatformImage>&& baselineImage, float tolerance, bool
printDifferance)

There’s a spelling error here where difference has an a instead of an E. I
recommend searching for “ifferance” and fixing them all.

> Tools/ImageDiff/ImageDiff.cpp:136
> +		   "  -d, --difference	    print WTP-style maxDifference and
totalPixels data\n" \

I think we mean WPT not WTP