[webkit-reviews] review granted: [Bug 232186] Bring up queues for Monterey : [Attachment 442225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 23 13:51:28 PDT 2021

Alexey Proskuryakov <ap at webkit.org> has granted Ryan Haddad
<ryanhaddad at apple.com>'s request for review:
Bug 232186: Bring up queues for Monterey

Attachment 442225: Patch


--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 442225
  --> https://bugs.webkit.org/attachment.cgi?id=442225

View in context: https://bugs.webkit.org/attachment.cgi?id=442225&action=review

> Tools/CISupport/build-webkit-org/config.json:174
> +		       { "name":
"Apple-Monterey-Release-WK2-WebGL-GPUProcess-Tests", "factory":
"TestAllButJSCFactory", "builddir":

Looks like we are moving this bot from Big Sur, not adding one for Monterey. Is
this the right thing to do?

> Tools/CISupport/build-webkit-org/wkbuild.py:81
>	   ("LayoutTests/platform/mac-bigsur", ["mac-bigsur"]),
> +	   ("LayoutTests/platform/mac-monterey", ["mac-monterey"]),

This looks wrong, changes to Monterey expectations should trigger tests on all
older OSes too. Same for Big Sur.

More information about the webkit-reviews mailing list