[webkit-reviews] review granted: [Bug 232194] Likely typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks() : [Attachment 442247] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 232194: Likely typo in 
MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()
https://bugs.webkit.org/show_bug.cgi?id=232194

Attachment 442247: Patch

https://bugs.webkit.org/attachment.cgi?id=442247&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 442247
  --> https://bugs.webkit.org/attachment.cgi?id=442247
Patch

Typically when we spot an obvious mistake like this, we spend a moment to try
to create a test that failed because of the error. It’s frustrating, because
likely if we had written the code correctly we would not have to think about
how to write a test.

Please consider if we could have tested. I have personally been in this
situation many times, spotted a typo that’s an obvious mistake and then was
frustrated at the challenge of writing a test to prove the code was
malfunctioning, and I understand if after thinking it over you do not find it’s
practical to test, but I would appreciate a specific comment saying so if that
happened.