[webkit-reviews] review granted: [Bug 232170] Add support for rel="noopener/noreferrer" on <form> elements : [Attachment 442222] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 232170: Add support for rel="noopener/noreferrer" on <form> elements
https://bugs.webkit.org/show_bug.cgi?id=232170

Attachment 442222: Patch

https://bugs.webkit.org/attachment.cgi?id=442222&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 442222
  --> https://bugs.webkit.org/attachment.cgi?id=442222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442222&action=review

> Source/WebCore/html/HTMLFormElement.cpp:78
> +static FormRelAttributes parseFormRelAttributes(StringView relAttribute)

I would call this "string".

> Source/WebCore/html/HTMLFormElement.cpp:80
> +    FormRelAttributes relAttributes;

I would call this "attributes".