[webkit-reviews] review granted: [Bug 232079] [JSC][32bit] Use DataIC in Baseline JIT : [Attachment 442137] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 17:28:42 PDT 2021

Yusuke Suzuki <ysuzuki at apple.com> has granted Geza Lore <glore at igalia.com>'s
request for review:
Bug 232079: [JSC][32bit] Use DataIC in Baseline JIT

Attachment 442137: Patch


--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 442137
  --> https://bugs.webkit.org/attachment.cgi?id=442137

View in context: https://bugs.webkit.org/attachment.cgi?id=442137&action=review

r=me with comment.

> Source/JavaScriptCore/jit/JITCall.cpp:-415
> -    emitJumpSlowCaseIfNotJSCell(baseGPR);

We should insert `static_assert(BaselineGetByIdRegisters::baseJSR ==
We have baseJSR. And it is possible that we will change baseJSR while keeping
resultJSR value.
Then, it is wrong that this code's base value register is not changed. To
notice that we are using returnValueJSR here instead, we should put
static_assert so that compilation error will happen.
baseJSR and resultJSR are the same, but this is not guaranteed thing.

More information about the webkit-reviews mailing list