[webkit-reviews] review granted: [Bug 232155] [Cocoa] Fairplay encrypted video fails to play when loaded in a display:none element : [Attachment 442211] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 232155: [Cocoa] Fairplay encrypted video fails to play when loaded in a
display:none element
https://bugs.webkit.org/show_bug.cgi?id=232155

Attachment 442211: Patch

https://bugs.webkit.org/attachment.cgi?id=442211&action=review




--- Comment #7 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 442211
  --> https://bugs.webkit.org/attachment.cgi?id=442211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442211&action=review

r=me with nit

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:112
>  
> -    if (supportsAcceleratedRendering() &&
m_player->renderingCanBeAccelerated())
> -	   return MediaRenderingToLayer;
> +    if ((m_readyState >= MediaPlayer::ReadyState::HaveMetadata &&
!haveBeenAskedToPaint()) || (supportsAcceleratedRendering() &&
m_player->renderingCanBeAccelerated()))
> +	   return MediaRenderingMode::MediaRenderingToLayer;

Nit: I might break this out into two statements for readability, and a smaller
diff:

if (supportsAcceleratedRendering() && m_player->renderingCanBeAccelerated())
    return MediaRenderingToLayer;

if (m_readyState >= MediaPlayer::ReadyState::HaveMetadata &&
!haveBeenAskedToPaint())
    return MediaRenderingToLayer;