[webkit-reviews] review canceled: [Bug 232113] REGRESSION (r284079): Audio continues playing on hulu.com in private browsing mode after closing the tab : [Attachment 442100] Minor renaming

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 10:54:58 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 232113: REGRESSION (r284079): Audio continues playing on hulu.com in
private browsing mode after closing the tab
https://bugs.webkit.org/show_bug.cgi?id=232113

Attachment 442100: Minor renaming

https://bugs.webkit.org/attachment.cgi?id=442100&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 442100
  --> https://bugs.webkit.org/attachment.cgi?id=442100
Minor renaming

View in context: https://bugs.webkit.org/attachment.cgi?id=442100&action=review

> Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:152
>      Ref<WebCore::ImageBuffer> m_imageBuffer;

This backpointer should be weak, since RemoteImageBuffer (strongly) owns its
RemoteDisplayListRecorder.

Going to make this adjustment along with the rest of this patch.


More information about the webkit-reviews mailing list