[webkit-reviews] review granted: [Bug 232124] video appears blank with only audio playing if video element isn't appended to the dom tree : [Attachment 442153] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 22 09:09:53 PDT 2021
Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 232124: video appears blank with only audio playing if video element isn't
appended to the dom tree
https://bugs.webkit.org/show_bug.cgi?id=232124
Attachment 442153: Patch
https://bugs.webkit.org/attachment.cgi?id=442153&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 442153
--> https://bugs.webkit.org/attachment.cgi?id=442153
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=442153&action=review
> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:483
> + if (RefPtr player = m_player.get()) {
Is this ref count churn helpful, wouldn't `auto* player = m_player.get()` work?
More information about the webkit-reviews
mailing list