[webkit-reviews] review granted: [Bug 232137] Factor style resolver context arguments into a struct : [Attachment 442161] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 232137: Factor style resolver context arguments into a struct
https://bugs.webkit.org/show_bug.cgi?id=232137

Attachment 442161: Patch

https://bugs.webkit.org/attachment.cgi?id=442161&action=review




--- Comment #5 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 442161
  --> https://bugs.webkit.org/attachment.cgi?id=442161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442161&action=review

> Source/WebCore/style/StyleResolver.h:83
> +struct ResolveContext {

Shouldn't this be called ResolutionContext rather? Resolve is a noun too, but
it doesn't mean the same thing, and a noun seems better than a verb here.