[webkit-reviews] review granted: [Bug 232127] Followup to r284652: ensure file handle is closed in web process : [Attachment 442129] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 232127: Followup to r284652: ensure file handle is closed in web process
https://bugs.webkit.org/show_bug.cgi?id=232127

Attachment 442129: Patch

https://bugs.webkit.org/attachment.cgi?id=442129&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 442129
  --> https://bugs.webkit.org/attachment.cgi?id=442129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442129&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp:65
> +    FileSystem::closeFile(m_file);

We are calling closeFile in WebProcess and NetworkProcess. Are both actually
needed?
I would hope we can move to a place where network process is only responsible
for opening the file handle, sending it to web process, locking/unlocking the
sync handle and doing quota checks.
WebProcess would be fully responsible to do everything else: getSize, flush,
read, write, close, truncate...

>
LayoutTests/storage/filesystemaccess/sync-access-handle-close-worker-expected.t
xt:537
> +[Worker] Create and close access handle No.511 successfully

Not sure we need that big of an expected file. Can we reduce its size?