[webkit-reviews] review denied: [Bug 232052] [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path : [Attachment 442016] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 232052: [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path
https://bugs.webkit.org/show_bug.cgi?id=232052

Attachment 442016: Patch

https://bugs.webkit.org/attachment.cgi?id=442016&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 442016
  --> https://bugs.webkit.org/attachment.cgi?id=442016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442016&action=review

r- since the new code is not great compared to the current 64bit
implementation.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:15891
> +	       flushRegisters();
> +

This is regressing 64bit implementation from the current one.
Can you remove it?
If this is necessary for 32bit implementation, so please keep 32bit and 64bit
implementations separated.