[webkit-reviews] review denied: [Bug 232052] [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path : [Attachment 442016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 16:05:09 PDT 2021

Yusuke Suzuki <ysuzuki at apple.com> has denied Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 232052: [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path

Attachment 442016: Patch


--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 442016
  --> https://bugs.webkit.org/attachment.cgi?id=442016

View in context: https://bugs.webkit.org/attachment.cgi?id=442016&action=review

r- since the new code is not great compared to the current 64bit

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:15891
> +	       flushRegisters();
> +

This is regressing 64bit implementation from the current one.
Can you remove it?
If this is necessary for 32bit implementation, so please keep 32bit and 64bit
implementations separated.

More information about the webkit-reviews mailing list