[webkit-reviews] review granted: [Bug 231989] Content offset in this codepen when switching tabs : [Attachment 442063] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 231989: Content offset in this codepen when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=231989

Attachment 442063: Patch

https://bugs.webkit.org/attachment.cgi?id=442063&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 442063
  --> https://bugs.webkit.org/attachment.cgi?id=442063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442063&action=review

> Tools/TestWebKitAPI/Tests/mac/ScrollingCoordinatorTests.mm:39
> +static void synthesizeWheelEvents(NSView *view, CGPoint locationInView,
CGSize delta)

Surely not unique to this test, should it be on TestWKWebView?

> Tools/TestWebKitAPI/Tests/mac/ScrollingCoordinatorTests.mm:82
> +	   return [obj hasPrefix:@"	   (last committed scroll position"];

Somewhat eww

> Tools/TestWebKitAPI/Tests/mac/ScrollingCoordinatorTests.mm:115
> +    NSWindow *hostWindow = [webView window];

Doesn't TestWKWebView have helpers for moving in and out of window too? I guess
your test is platform specific so it doesn't really matter.

> Tools/TestWebKitAPI/Tests/mac/ScrollingCoordinatorTests.mm:125
> +    scrollY = waitForScrollEventAndReturnScrollY(webView.get(),
[](WKWebView* webView) {

Star's on the wrong side etc.