[webkit-reviews] review denied: [Bug 231789] WebDriver: [Cocoa] support `acceptInsecureCerts` capability : [Attachment 442056] Patch v1.2 - Address BJ's review notes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 12:48:29 PDT 2021


Alex Christensen <achristensen at apple.com> has denied Patrick Angle
<pangle at apple.com>'s request for review:
Bug 231789: WebDriver: [Cocoa] support `acceptInsecureCerts` capability
https://bugs.webkit.org/show_bug.cgi?id=231789

Attachment 442056: Patch v1.2 - Address BJ's review notes

https://bugs.webkit.org/attachment.cgi?id=442056&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 442056
  --> https://bugs.webkit.org/attachment.cgi?id=442056
Patch v1.2 - Address BJ's review notes

View in context: https://bugs.webkit.org/attachment.cgi?id=442056&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2164
> +void NetworkProcess::acceptInsecureCertificatesForAutomation(PAL::SessionID
sessionID)

This isn't needed, as discussed offline.  This state can be kept in the UI
process.  Please remove.


More information about the webkit-reviews mailing list