[webkit-reviews] review granted: [Bug 231971] http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky timeout : [Attachment 442044] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 10:29:28 PDT 2021


John Wilander <wilander at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 231971:
http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-wi
th-link-decoration.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=231971

Attachment 442044: Patch

https://bugs.webkit.org/attachment.cgi?id=442044&action=review




--- Comment #21 from John Wilander <wilander at apple.com> ---
Comment on attachment 442044
  --> https://bugs.webkit.org/attachment.cgi?id=442044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442044&action=review

r=me with comment. Also, see if you can get the style checker to be happy.

> LayoutTests/http/tests/resourceLoadStatistics/resources/util.js:19
> +	   "http://127.0.0.1:8000",

Could we make this a parameter instead? And throw an error if the current
location doesn't match the parameter? That would make it explicit to anyone
using the function and also avoid mistakes.


More information about the webkit-reviews mailing list