[webkit-reviews] review granted: [Bug 231114] [WebAssembly][modules] Importing globals into Wasm from JS doesn't work : [Attachment 441794] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Asumu Takikawa
<asumu at igalia.com>'s request for review:
Bug 231114: [WebAssembly][modules] Importing globals into Wasm from JS doesn't
work
https://bugs.webkit.org/show_bug.cgi?id=231114

Attachment 441794: Patch

https://bugs.webkit.org/attachment.cgi?id=441794&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 441794
  --> https://bugs.webkit.org/attachment.cgi?id=441794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441794&action=review

r=me

> Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:840
>	   return jsModuleRecord->evaluate(globalObject, sentValue,
resumeMode);

Replace it with

RELEASE_AND_RETURN(scope, jsModuleRecord->evaluate(globalObject, sentValue,
resumeMode));

since scope is defined now.

> Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:848
>	   return wasmModuleRecord->evaluate(globalObject);

Replace it with

RELEASE_AND_RETURN(scope, wasmModuleRecord->evaluate(globalObject));