[webkit-reviews] review granted: [Bug 232070] StreamConnectionWorkQueue::processStreams() has a incorrect protection ref : [Attachment 441997] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 232070: StreamConnectionWorkQueue::processStreams() has a incorrect
protection ref
https://bugs.webkit.org/show_bug.cgi?id=232070

Attachment 441997: Patch

https://bugs.webkit.org/attachment.cgi?id=441997&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 441997
  --> https://bugs.webkit.org/attachment.cgi?id=441997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441997&action=review

> Source/WebKit/ChangeLog:12
> +	   task, and since `stop()` waits until queue has executed the

In that case, I think we should consider renaming `stop()` to
`stopAndWaitForTasksToComplete()`, to make it clear that it must always block
on the work queue thread.