[webkit-reviews] review granted: [Bug 231992] [Cocoa] Merge and simplify the nsColor family of functions : [Attachment 441906] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 231992: [Cocoa] Merge and simplify the nsColor family of functions
https://bugs.webkit.org/show_bug.cgi?id=231992

Attachment 441906: Patch

https://bugs.webkit.org/attachment.cgi?id=441906&action=review




--- Comment #5 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 441906
  --> https://bugs.webkit.org/attachment.cgi?id=441906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441906&action=review

> Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm:38
> +RetainPtr<UIColor> cocoaColor(const Color& color)

Can/should this assert if the passed in color is invalid?