[webkit-reviews] review granted: [Bug 231990] WebKit should process-swap for initial navigation of a popup if it has no opener : [Attachment 441979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 23:54:58 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 231990: WebKit should process-swap for initial navigation of a popup if it
has no opener
https://bugs.webkit.org/show_bug.cgi?id=231990

Attachment 441979: Patch

https://bugs.webkit.org/attachment.cgi?id=441979&action=review




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 441979
  --> https://bugs.webkit.org/attachment.cgi?id=441979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441979&action=review

R=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1296
> +    EXPECT_NE(pid1, pid2);

Is it worth having a test for the named window case to confirm it doesn’t
process swap?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1387
> +    // Since the window was open via JS, it should be able to close itself.

“Was opened”


More information about the webkit-reviews mailing list