[webkit-reviews] review denied: [Bug 231986] Fix crash when calling setUsernameForLocalCredentialWithID : [Attachment 441819] Follow up patch to address comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 15:34:03 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has denied	review:
Bug 231986: Fix crash when calling setUsernameForLocalCredentialWithID
https://bugs.webkit.org/show_bug.cgi?id=231986

Attachment 441819: Follow up patch to address comment

https://bugs.webkit.org/attachment.cgi?id=441819&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 441819
  --> https://bugs.webkit.org/attachment.cgi?id=441819
Follow up patch to address comment

View in context: https://bugs.webkit.org/attachment.cgi?id=441819&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:319
> +    NSDictionary *attributes = (__bridge NSDictionary *)attributesArrayRef);

Oops! extra parentheses here!


More information about the webkit-reviews mailing list