[webkit-reviews] review granted: [Bug 232021] Factor out some Notifications-specific messages from WebPageProxy messages : [Attachment 441895] Patch v1

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 232021: Factor out some Notifications-specific messages from WebPageProxy
messages
https://bugs.webkit.org/show_bug.cgi?id=232021

Attachment 441895: Patch v1

https://bugs.webkit.org/attachment.cgi?id=441895&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 441895
  --> https://bugs.webkit.org/attachment.cgi?id=441895
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=441895&action=review

>
Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h:36
> +public:
> +    WebNotificationManagerMessageHandler(WebPageProxy&);

You might consider making the constructor private and befriending WebPageProxy
so that only WebPageProxy can construct it.  We usually try to avoid friend,
but I think in this case it would be a reasonable choice.

>
Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h:39
> +    void showNotification(const String& title, const String& body, const
String& iconURL, const String& tag, const String& lang,
WebCore::NotificationDirection, const String& originString, uint64_t
notificationID) final;

nit: lang should be a full word.

>
Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h:40
> +    void cancelNotification(uint64_t notificationID) final;

nit: this should be an ObjectIdentifier of some type.