[webkit-reviews] review granted: [Bug 197100] [GTK] Slow scrolling (not matching GTK native scroll amount) : [Attachment 441891] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Lord
<clord at igalia.com>'s request for review:
Bug 197100: [GTK] Slow scrolling (not matching GTK native scroll amount)
https://bugs.webkit.org/show_bug.cgi?id=197100

Attachment 441891: Patch

https://bugs.webkit.org/attachment.cgi?id=441891&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 441891
  --> https://bugs.webkit.org/attachment.cgi?id=441891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441891&action=review

> Source/WebCore/platform/ScrollAnimationSmooth.cpp:81
> +    m_timingFunction =
CubicBezierTimingFunction::create(CubicBezierTimingFunction::TimingFunctionPres
et::EaseOut);

It's possible that this won't result in a smooth transition from old to new
curve. Ideally we'd keep the ease-in-out and just readjust the current time
within the existing interval.