[webkit-reviews] review granted: [Bug 231985] Do GraphicsContext and EventRegion clipping-related save/restore via RAII objects : [Attachment 441802] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 231985: Do GraphicsContext and EventRegion clipping-related save/restore
via RAII objects
https://bugs.webkit.org/show_bug.cgi?id=231985

Attachment 441802: Patch

https://bugs.webkit.org/attachment.cgi?id=441802&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 441802
  --> https://bugs.webkit.org/attachment.cgi?id=441802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441802&action=review

> Source/WebCore/rendering/RenderLayer.cpp:3846
> +	   GraphicsContextStateSaver stateSaver(context, false);
> +	   EventRegionContextStateSaver
eventRegionStateSaver(localPaintingInfo.eventRegionContext);

This seems bit error-prone. Maybe we should have another class
(ClipStateSaver?) that owns both of these?