[webkit-reviews] review granted: [Bug 219813] `navigator.credentials.create()` returns immediately with `NotAllowedError` if credential already registered. : [Attachment 441790] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 219813: `navigator.credentials.create()` returns immediately with
`NotAllowedError` if credential already registered.
https://bugs.webkit.org/show_bug.cgi?id=219813

Attachment 441790: Patch

https://bugs.webkit.org/attachment.cgi?id=441790&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 441790
  --> https://bugs.webkit.org/attachment.cgi?id=441790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441790&action=review

> Source/WebKit/ChangeLog:11
> +	   A fixme to add this was inadvertently removed in 
https://bugs.webkit.org/attachment.cgi?id=393180&action=prettypatch

nit: extra space before URL

> Source/WebKit/ChangeLog:13
> +	   Reviewed by NOBODY (OOPS!).

This is supposed to come *before* the description, not after.