[webkit-reviews] review granted: [Bug 231976] canDoFastSpread should also check that the Structure is from the global object we're watching : [Attachment 441776] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 19 13:05:10 PDT 2021
Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 231976: canDoFastSpread should also check that the Structure is from the
global object we're watching
https://bugs.webkit.org/show_bug.cgi?id=231976
Attachment 441776: Patch
https://bugs.webkit.org/attachment.cgi?id=441776&action=review
--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 441776
--> https://bugs.webkit.org/attachment.cgi?id=441776
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=441776&action=review
> Source/JavaScriptCore/dfg/DFGGraph.cpp:1852
> + && structure->globalObject() == globalObject
> && structure->storedPrototype() == arrayPrototype
Nit: Can we invert these two lines?
More information about the webkit-reviews
mailing list