[webkit-reviews] review granted: [Bug 231815] [libpas] Enable libpas on macOS : [Attachment 441662] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 231815: [libpas] Enable libpas on macOS
https://bugs.webkit.org/show_bug.cgi?id=231815

Attachment 441662: Patch

https://bugs.webkit.org/attachment.cgi?id=441662&action=review




--- Comment #21 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 441662
  --> https://bugs.webkit.org/attachment.cgi?id=441662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441662&action=review

> Source/bmalloc/libpas/src/libpas/pas_utils_prefix.h:-50
> -#ifdef __OPTIMIZE__
>  #define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE
__attribute__((__always_inline__))
> -#else
> -#define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE
> -#endif
> -

Is this change still necessary?

If it's not, then I'd kill it, since in those cases where you actually have to
debug libpas (and build it in debug mode), you'll want the inlining turned off.