[webkit-reviews] review granted: [Bug 231906] REGRESSION(r284313): ::marker accelerated animations are broken : [Attachment 441718] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 231906: REGRESSION(r284313): ::marker accelerated animations are broken
https://bugs.webkit.org/show_bug.cgi?id=231906

Attachment 441718: Patch

https://bugs.webkit.org/attachment.cgi?id=441718&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 441718
  --> https://bugs.webkit.org/attachment.cgi?id=441718
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441718&action=review

> Source/WebCore/style/PropertyAllowlist.cpp:41
> +// https://www.w3.org/TR/css-pseudo-4/#marker-pseudo (Editor's Draft, 25
July 2017)
> +// FIXME: this is outdated, see
https://bugs.webkit.org/show_bug.cgi?id=218791.
> +bool isValidMarkerStyleProperty(CSSPropertyID id)

It sounded from spec reading in slack that this allow list is a wrong approach.
All properties should be visible in the computed style and the rendering code
should be ignoring whatever is disallowed.

This refactoring ends up being bit useless if we just delete all code here soon
but I suppose it doesn't hurt.