[webkit-reviews] review granted: [Bug 231803] Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support : [Attachment 441707] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 19 08:37:31 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 231803: Add support for requestVideoFrameCallback API and
MediaStreamTrack-based backend support
https://bugs.webkit.org/show_bug.cgi?id=231803

Attachment 441707: Patch

https://bugs.webkit.org/attachment.cgi?id=441707&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 441707
  --> https://bugs.webkit.org/attachment.cgi?id=441707
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441707&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:583
> +    if (m_nextVideoFrameRequestIndex ==
std::numeric_limits<unsigned>::max())
> +	   return 0;

This probably log an error, possibly also to the JS console


More information about the webkit-reviews mailing list