[webkit-reviews] review requested: [Bug 231952] [css-flexbox] Add support for replaced elements with intrinsic ratio and no intrinsic size : [Attachment 441722] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has asked  for review:
Bug 231952: [css-flexbox] Add support for replaced elements with intrinsic
ratio and no intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=231952

Attachment 441722: Patch

https://bugs.webkit.org/attachment.cgi?id=441722&action=review




--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 441722
  --> https://bugs.webkit.org/attachment.cgi?id=441722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441722&action=review

>> Source/WebCore/rendering/RenderFlexibleBox.cpp:621
>> +static bool isRenderReplacedWithIntrinsicAspectRatio(const RenderBox&
child)
> 
> I think it is worth trying to make this a method on RenderReplaced instead of
static, so we do not need to make computeIntrinsicRatioInformation public on
RenderReplaced.h.

Good suggestion. I filed wkb.ug/231955 to tackle this.

>> Source/WebCore/rendering/RenderFlexibleBox.cpp:625
>> +	// It's common for some replaced elements, such SVGs, to have intrinsic
aspect ratios but no intrinsic sizes.
> 
> "such as SVGs"

OK