[webkit-reviews] review granted: [Bug 231664] Guarantee order of WebSocket events in case of being resumed : [Attachment 441702] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 231664: Guarantee order of WebSocket events in case of being resumed
https://bugs.webkit.org/show_bug.cgi?id=231664

Attachment 441702: Patch

https://bugs.webkit.org/attachment.cgi?id=441702&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 441702
  --> https://bugs.webkit.org/attachment.cgi?id=441702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441702&action=review

Nice, r=me with fixes.

> Source/WebCore/Modules/websockets/WebSocket.cpp:554
> +	   ASSERT(scriptExecutionContext());

Please do an early return, there is no such guarantee with the event loop as
the event loop is shared with other contexts of the same origin.

> Source/WebCore/Modules/websockets/WebSocket.cpp:568
> +	   ASSERT(scriptExecutionContext());

ditto.

> Source/WebCore/Modules/websockets/WebSocket.cpp:598
> +	   ASSERT(scriptExecutionContext());

ditto.

> Source/WebCore/Modules/websockets/WebSocket.cpp:632
> +	   ASSERT(scriptExecutionContext());

ditto.