[webkit-reviews] review requested: [Bug 231922] Add NetworkProcess stubs for push subscriptions : [Attachment 441668] Patch

[bugzilla-daemon at webkit.org]

Ben Nham <nham at apple.com> has asked  for review:
Bug 231922: Add NetworkProcess stubs for push subscriptions
https://bugs.webkit.org/show_bug.cgi?id=231922

Attachment 441668: Patch

https://bugs.webkit.org/attachment.cgi?id=441668&action=review




--- Comment #5 from Ben Nham <nham at apple.com> ---
Comment on attachment 441668
  --> https://bugs.webkit.org/attachment.cgi?id=441668
Patch

One note is that the IPC parser didn't seem to handle a return type of
Expected<enum:uint8_t PushPermissionState, ExceptionData> properly (its codegen
tried to emit an #include<enum:uint8_t ...> in the cpp file). For now that IPC
message just returns an Expected<uint8_t, ExceptionData> until I can take a
look at that codegen issue in a separate patch.