[webkit-reviews] review granted: [Bug 231771] Add a callback to know when the service worker loads via -[WKWebView _loadServiceWorker:] : [Attachment 441624] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 231771: Add a callback to know when the service worker loads via
-[WKWebView _loadServiceWorker:]
https://bugs.webkit.org/show_bug.cgi?id=231771

Attachment 441624: Patch

https://bugs.webkit.org/attachment.cgi?id=441624&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 441624
  --> https://bugs.webkit.org/attachment.cgi?id=441624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441624&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4812
> +	       m_serviceWorkerLaunchCompletionHandler(false);

I think you need this in the destructor too.