[webkit-reviews] review granted: [Bug 231574] Expose MediaCapabilities to Workers : [Attachment 441587] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 18 09:17:03 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 231574: Expose MediaCapabilities to Workers
https://bugs.webkit.org/show_bug.cgi?id=231574

Attachment 441587: Patch

https://bugs.webkit.org/attachment.cgi?id=441587&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 441587
  --> https://bugs.webkit.org/attachment.cgi?id=441587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441587&action=review

> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:-197
> -#if !RELEASE_LOG_DISABLED
> -	   logger->info(LogMedia, identifier, " - Rejected. configuration: ",
configuration);
> -#endif

Why not log the error?


More information about the webkit-reviews mailing list