[webkit-reviews] review granted: [Bug 231890] Close peer connection sockets when entering page cache : [Attachment 441586] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 18 08:49:02 PDT 2021
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 231890: Close peer connection sockets when entering page cache
https://bugs.webkit.org/show_bug.cgi?id=231890
Attachment 441586: Patch
https://bugs.webkit.org/attachment.cgi?id=441586&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 441586
--> https://bugs.webkit.org/attachment.cgi?id=441586
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=441586&action=review
> LayoutTests/webrtc/datachannel/datachannel-page-cache-send.html:37
> + waitForConnectionState(pc1.connectionState, "disconnected");
Should this be `await waitForConnectionState(pc1.connectionState,
"disconnected")` ?
More information about the webkit-reviews
mailing list