[webkit-reviews] review granted: [Bug 225590] [css-flexbox] Do not clamp flex base size with {min|max}-{height|width} : [Attachment 441578] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 225590: [css-flexbox] Do not clamp flex base size with
{min|max}-{height|width}
https://bugs.webkit.org/show_bug.cgi?id=225590

Attachment 441578: Patch

https://bugs.webkit.org/attachment.cgi?id=441578&action=review




--- Comment #13 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 441578
  --> https://bugs.webkit.org/attachment.cgi?id=441578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441578&action=review

r=me, let's hope there's no more unexpected breakage.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1010
> +	   m_originalMin = m_isHorizontalWritingModeInParallelFlow ?
m_child.style().minWidth() : m_child.style().minHeight();
> +	   m_originalMax = m_isHorizontalWritingModeInParallelFlow ?
m_child.style().maxWidth() : m_child.style().maxHeight();

Nit: We've the very same if just below, maybe we can put this inside that if
directly.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1048
>      Length m_originalLength;
> +    Length m_originalMin;
> +    Length m_originalMax;

Nit: I've the feeling that m_originalSize, m_originalMinSize and
m_originalMaxSize might be easier to understand.