[webkit-reviews] review granted: [Bug 231059] [GStreamer] fast/mediastream/video-rotation tests are failing due to missing TestController::takeViewPortSnapshot : [Attachment 441572] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 231059: [GStreamer] fast/mediastream/video-rotation tests are failing due
to missing TestController::takeViewPortSnapshot
https://bugs.webkit.org/show_bug.cgi?id=231059

Attachment 441572: Patch

https://bugs.webkit.org/attachment.cgi?id=441572&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 441572
  --> https://bugs.webkit.org/attachment.cgi?id=441572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013
> +	   GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no
rotation.");

This message is confusing, since it says you're not applying rotation but
you're applying orientation in the end. Or maybe I'm misunderstanding...