[webkit-reviews] review granted: [Bug 231123] [WebXR] Stubs for WebXR Hand Input Module : [Attachment 441548] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 231123: [WebXR] Stubs for WebXR Hand Input Module
https://bugs.webkit.org/show_bug.cgi?id=231123

Attachment 441548: Patch

https://bugs.webkit.org/attachment.cgi?id=441548&action=review




--- Comment #22 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 441548
  --> https://bugs.webkit.org/attachment.cgi?id=441548
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441548&action=review

> Source/WebCore/Modules/webxr/WebXRFrame+HandInput.idl:26
> +[

Please add a spec link matching the other idl files.

> Source/WebCore/Modules/webxr/WebXRHand.h:49
> +    unsigned long size() { return m_size; }

This should just be an 'unsigned'. The name 'unsigned long' in WebIDL maps to
our 'unsigned'.

> Source/WebCore/Modules/webxr/WebXRHand.h:70
> +    unsigned long m_size { 0 };

Same as above. 'unsigned'.

> Source/WebCore/Modules/webxr/WebXRInputSource+HandInput.idl:30
> +    //
https://immersive-web.github.io/webxr-hand-input/#xrinputsource-interface

Please put the spec link above the extended attributes matching the other IDLs.

> Source/WebCore/Modules/webxr/XRHandJoint.idl:26
> +[

Please add spec link.

> LayoutTests/ChangeLog:9
> +	   New test that checks an XRHand object can survive garbage
collection.

Be good to have tests for WebXRJointSpace as well, but that can happen in time.