[webkit-reviews] review denied: [Bug 231865] Share stacking context code between RenderLayer & StyleAdjuster : [Attachment 441498] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 231865: Share stacking context code between RenderLayer & StyleAdjuster
https://bugs.webkit.org/show_bug.cgi?id=231865

Attachment 441498: Patch

https://bugs.webkit.org/attachment.cgi?id=441498&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 441498
  --> https://bugs.webkit.org/attachment.cgi?id=441498
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441498&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:2790
> +	   || hasTransformRelatedProperty()

I think this is a behavior change because
renderer.hasTransformRelatedProperty() is not always equivalent to
style.hasTransformRelatedProperty() since transforms don't apply to non-atomic
lines.