[webkit-reviews] review granted: [Bug 228302] macOS key-driven smooth scrolling does not stop when focus changes : [Attachment 441472] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 228302: macOS key-driven smooth scrolling does not stop when focus changes
https://bugs.webkit.org/show_bug.cgi?id=228302

Attachment 441472: Patch

https://bugs.webkit.org/attachment.cgi?id=441472&action=review




--- Comment #27 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 441472
  --> https://bugs.webkit.org/attachment.cgi?id=441472
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441472&action=review

> Source/WebCore/page/Page.cpp:2383
> +	   const HashSet<ScrollableArea*>* scrollableAreas =
frameView->scrollableAreas();

auto?

> Tools/DumpRenderTree/mac/EventSendingController.mm:1033
> +

Extra line.

> LayoutTests/ChangeLog:8
> +	   useFlexibleViewport and
EventHandlerDrivenSmoothKeyboardScrollingEnabled keys are WK2 only 

The useFlexibleViewport thing isn't relevant any more.