[webkit-reviews] review granted: [Bug 230941] Some WebIDL operations / attributes incorrectly use _current_ realm instead of _relevant_ : [Attachment 439585] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 230941: Some WebIDL operations / attributes incorrectly use _current_ realm
instead of _relevant_
https://bugs.webkit.org/show_bug.cgi?id=230941

Attachment 439585: Patch

https://bugs.webkit.org/attachment.cgi?id=439585&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 439585
  --> https://bugs.webkit.org/attachment.cgi?id=439585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439585&action=review

> Source/WebCore/ChangeLog:22
> +	   Most of the remaining [CallWith=GlobalObject] instances are
correctly used for
> +	   converting JS arguments to WebIDL values; the rest, along with
_current_ Document
> +	   and ScriptExecutionContext, either match the spec or replacing them
with _relevant_
> +	   global object is not directly observable (see condition #3).

It would be great to have some guidance to others in the future that need to
figure out which the correct document/globalObject,scriptExecutionContext is
the right one to use (though I don't have a great idea where to put this
guidance).