[webkit-reviews] review granted: [Bug 231468] Query EGL_BIND_TO_TEXTURE_TARGET_ANGLE to determine 2D/rectangular texture usage : [Attachment 441412] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 231468: Query EGL_BIND_TO_TEXTURE_TARGET_ANGLE to determine 2D/rectangular
texture usage
https://bugs.webkit.org/show_bug.cgi?id=231468

Attachment 441412: Patch

https://bugs.webkit.org/attachment.cgi?id=441412&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 441412
  --> https://bugs.webkit.org/attachment.cgi?id=441412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441412&action=review

Looks good to me. Couple of small comments about the asserts. r+

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:471
> +    ASSERT(!"Invalid enum returned from EGL_GetConfigAttrib");

This is the first I've seen this trick used to incorporate a message. Consider
ASSERT_WITH_MESSAGE(false, ...).

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:484
> +    ASSERT(!"Invalid drawing target");

Same here.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:497
> +    assert(!"Invalid drawing target");

Please use WebKit's ASSERT macro.