[webkit-reviews] review granted: [Bug 230469] Inline RegExp.test JIT code in DFG and FTL : [Attachment 440102] Patch with changes from review

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 230469: Inline RegExp.test JIT code in DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=230469

Attachment 440102: Patch with changes from review

https://bugs.webkit.org/attachment.cgi?id=440102&action=review




--- Comment #18 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 440102
  --> https://bugs.webkit.org/attachment.cgi?id=440102
Patch with changes from review

View in context: https://bugs.webkit.org/attachment.cgi?id=440102&action=review

r=me with the stuff we spoke about when talking on the phone

> Source/JavaScriptCore/yarr/YarrJIT.cpp:4100
> +	   m_boyerMooreData = dynamic_cast<YarrBoyerMoyerData*>(m_codeBlock);

dynamic_cast?
Why not static_cast?

> Source/JavaScriptCore/yarr/YarrJITRegisters.h:32
> +#define YARR_CALL

don't think this is needed.