[webkit-reviews] review granted: [Bug 230008] Accelerated animations on ::backdrop shouldn't affect <dialog> (backdrop-animate-002.html fails) : [Attachment 441256] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 13:14:59 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 230008: Accelerated animations on ::backdrop shouldn't affect <dialog>
(backdrop-animate-002.html fails)
https://bugs.webkit.org/show_bug.cgi?id=230008

Attachment 441256: Patch

https://bugs.webkit.org/attachment.cgi?id=441256&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 441256
  --> https://bugs.webkit.org/attachment.cgi?id=441256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441256&action=review

> Source/WebCore/style/Styleable.cpp:86
> +    if (pseudoId == PseudoId::After) {
> +	   if (auto* afterPseudoElement = element.afterPseudoElement())
> +	       return afterPseudoElement->renderer();
> +    } else if (pseudoId == PseudoId::Backdrop) {
> +	   if (auto* hostRenderer = element.renderer())
> +	       return hostRenderer->backdropRenderer().get();
> +    } else if (pseudoId == PseudoId::Before) {
> +	   if (auto* beforePseudoElement = element.beforePseudoElement())
> +	       return beforePseudoElement->renderer();
> +    } else if (pseudoId == PseudoId::Marker) {
> +	   if (is<RenderListItem>(element.renderer()))
> +	       return
downcast<RenderListItem>(*element.renderer()).markerRenderer();
> +    } else if (pseudoId == PseudoId::None)
> +	   return element.renderer();

Switch


More information about the webkit-reviews mailing list