[webkit-reviews] review granted: [Bug 231682] REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails : [Attachment 441126] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 231682: REGRESSION (r283667):
webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
https://bugs.webkit.org/show_bug.cgi?id=231682

Attachment 441126: Patch

https://bugs.webkit.org/attachment.cgi?id=441126&action=review




--- Comment #5 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 441126
  --> https://bugs.webkit.org/attachment.cgi?id=441126
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441126&action=review

some whitespace issues..

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:26
1
> +		   << "ANGLE_vertexOut.";

whitespace: maybe match the indent or align the whole statement.

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:26
2
> +		   if(!varying.isBuiltIn())

nit: space after if